2268: My incoming reviews have a negative number

yeomans*******@gmai***** (Google Code) (Is this you? Claim this profile.)
June 17, 2014
2273, 2277, 2645, 2738, 3107, 3284, 3415, 3519, 3523
What version are you running?
1.6 RC2

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1.I just opened my dashboard

What is the expected output? What do you see instead?
A number without the negative sign.

What operating system are you using? What browser?
Windows 7
Firefox 6.0

Please provide any additional information below.
I attached a picture
#1 david
This was a bug in 1.6rc1. Please run 'rb-site /path/to/site manage fixreviewcounts' on the server.
  • +Fixed
#2 Duan*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I just upgraded from RB 1.5.5 to 1.6 and encountered this same issue.  Does the 'rb-site manage fixreviewcounts' command fix this permanently?
#3 david
Yes, it should.
#4 chipx86
It may not fix it forever. We actually call this on upgrade. There may very well be a bug here. It will be extremely helpful to have a solid repro case. This means knowing exactly what actions were performed on the review request in what order, knowing which counter field is broken, etc.
  • -Fixed
#5 Duan*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Here are the steps I went through:

1) Created four review requests by three different users other than me in RB (this was a new installation).
2) Opened up my dashboard to see the four review requests (I was specifically added as a reviewer on three of them).
3) Went to the other developers machine and had him close review request #1.
4) Refreshed my dashboard and saw the negative numbers (see attached).  I believe the numbers should have been 3 for incoming reviews (versus -1) and 2 'to me' (versus -1).
5) Ran the fixreviewcounts script, restarted httpd and memcached and all was well.
#7 manjuna********@gmai***** (Google Code) (Is this you? Claim this profile.)
When I upgraded from 1.5 to 1.6, i got -1 for "Outgoing Reviews" and zero for all the other case (example All My Requests). When I ran "rb-site manage <path/to/site> fixreviewcounts", counts were seen correctly (All My Requests now 83). 
#10 chipx86
Fixed on master and release-1.6.x.
  • -NeedInfo
  • -Priority-Medium
  • +chipx86
#11 gdn***@motoro****** (Google Code) (Is this you? Claim this profile.)
We have the same issue with version 1.7.2. Does the fixreviewcounts also work for that version? 
#12 david
Yes, it does.
#13 cjac****@yelp**** (Google Code) (Is this you? Claim this profile.)
This is still happening for me. In the attached screenshot I should have 0 starred, 1 outgoing (though it's not published yet, I forget if that counts) and 22 incoming reviews.

Is there a workaround in admin to reset the counts?
#14 cjac****@yelp**** (Google Code) (Is this you? Claim this profile.)
Sorry - I'm on 1.6.13
#15 ri***@fryo***** (Google Code) (Is this you? Claim this profile.)
this seems to be fixed per https://code.google.com/p/reviewboard/issues/detail?id=2645 - can we merge this on to the next 1.7.x release? It happens on 1.7.6 for me.
#16 chipx86
Can you try a modern 1.7.x release? We attempted another fix a little while back.
#17 chipx86
  • -Fixed
  • -Djblets
#22 dichlo******@gmai***** (Google Code) (Is this you? Claim this profile.)
Can you please specify the exact 1.7.x branch version where this bug was presumably finally fixed?
#23 chipx86
It's pending review, and is not on any branch yet.
#25 chipx86
Should now be fixed on release-1.7.x (d39241f) and release-2.0.x (99b2e1a)
  • -Started