Review Board

Here's the latest...

No new tickets were filed this week. That's a relief.
No tickets were closed this week. Better get on that.

Some recent discussions you might care about...

#3 a-dogg

So just to reiterate, the problem appears to be, RB is not fetching the left-hand-side file contents correctly.

RB should be able to fetch the left-hand-side file contents correctly. The files were deleted in SVN and don't exist at HEAD revision, but they do exist at the revision specified in the patch file.

E.g.:

$ svn cat $NETREPO/espresso/trunk/product-spec.json
svn: warning: W160013: File not found: revision 1887978, path '/espresso/trunk/product-spec.json'
svn: E200009: Could not cat all targets because some targets don't exist
svn: E200009: Illegal target for the requested operation

# If I download the diff from the RB, the 1st line for each file-entry reads like:
#    "--- espresso/trunk/product-spec.json  (revision 1695130)"
# ... which tells me the left-hand-side file contents should be fetched from revision 1695130
$ svn cat $NETREPO/espresso/trunk/product-spec.json@1695130 | tail -5
    "databases": {},
    "repo_name": "DDS"
  },
  "description": "Elastic, Scalable, Performant, Reliable, Extensible, Stable, Speedy, and Operational"
}

As you can see, it is possible to fetch the correct left-hand-side file contents, given the correct revision, but for whatever reason reviewboard doesn't seem to be doing that - it is failing out due to the fact that the files no longer exist at the specified location.

#1 amiryal

Actually, my shell_quote implementation can’t work, even if I add handling of quotation characters and backslashes, because I could not find a way to escape newline characters.