895: Deletion and addition of 0-length files are not included in review
- Review Board
|rock****@gmai***** (Google Code) (Is this you? Claim this profile.)|
|May 28, 2014|
|1213, 1425, 2759, 3432|
What's the URL of the page containing the problem? https://reviewboard.eng.vmware.com/r/62290/ What steps will reproduce the problem? 1. Use Perforce to delete a set of files at least one of which is a 0-length file (e.g., __init__.py). 2. Run post-review. For each 0-length file there will be a message: Warning: [path to 0-length file] in your changeset is unmodified 3. The 0-length files will not be listed in the review. What is the expected output? What do you see instead? I would expect post-review to know that the 0-length files have been deleted and for this information to be communicated in the diff section of the review. What operating system are you using? What browser? OS is x86_64 Red Hat Enterprise Linux WS release 4 (Nahant Update 4). Browser is Firefox 3.0.6. Please provide any additional information below.
Unfortunately, there's no actual diff for these sorts of files. We can try to add this sort of thing down the line but right now there are much bigger fish to fry.
- Priority-Medium + Priority-Low
+ Deletion and addition of 0-length files are not included in review
+ Component-RBTools + Component-DiffViewer
Fixed in git. This requires: reviewboard master (836665a) rbtools release-0.6.x (bfec7b3) This will ship in Review Board 2.1
- Confirmed + Fixed