What version are you running?
1.1 Alpha 2 in a post-commit setup
What's the URL of the page containing the problem?
Private
What steps will reproduce the problem?
1. ./post-commit /var/lib/svn/repo 14
2.
3.
What is the expected output? What do you see instead?
Successful review
What operating system are you using? What browser?
CentOS 5.2 + subversion 1.5.7
Please provide any additional information below.
Problem appears to be the diff generated. The revision is only the deletion
of empty ".sf" files.
Command ran by post-review to obtain diff:
svn diff --diff-cmd=diff file:///var/lib/svn/repo/@13
file:///var/lib/svn/repo/@14
Output of diff:
Index: //trunk/test/unit/.sf
===================================================================
Index: //trunk/test/functional/.sf
===================================================================
Index: //trunk/test/functional/frontend/.sf
===================================================================
Due to the ambiguity of the diff, there might be a few possible work-arounds:
1. Change subversion command to include "--no-diff-deleted" which adds
"(deleted)" to the diff Index line.
2. Add a diff wrapper command that will convert empty diffs to
understandable diffs.
3. Change ReviewBoard to accept/understand empty diffs which signifies a
deletion or addition depending on whether the file exists or not.
Thanks
Rob O.
Ender Tech Corp.
www.endertech.com
