4529: Editing comments in the drop-down editor doesn't update comments in the diff; text loss possible


What version are you running?

3.0 alpha 0

What's the URL of the page containing the problem?

Any review request with a diff

What steps will reproduce the problem?

  1. Add an issue in the diff (Click on a line, type something, press [Save]). The green "You have a pending review" bar should appear.
  2. Click "Edit Review". All comments should be shown in the further drop-down sub-window.
  3. Click on the issue text, to start editing it.
  4. Edit the text of the issue.
  5. Press OK.
  6. Press [Close].

What is the expected output? What do you see instead?


In the diff view, the issue visibile on hover has been updated to the new text.


The old text is still visible there. Clicking on it also shows the old text.

What operating system are you using? What browser?

OSX, Firefox 52

Please provide any additional information below.

If one would edit that issue (by clicking on it) in the diff viewer, it will silently overwrite the content written at step 4. That might lead to confusion.

This ticket was originally filed in Bugzilla for MozReview: https://bugzilla.mozilla.org/show_bug.cgi?id=1338073