3954: Error 500 to some tickets

atrub******@eisgro****** (Google Code) (Is this you? Claim this profile.)
3747
3956 
Here is the output from admin email
Traceback (most recent call last):

  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)

  File "/usr/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/accounts/decorators.py", line 21, in _check
    return login_required(view_func)(*args, **kwargs)

  File "/usr/lib/python2.7/site-packages/django/contrib/auth/decorators.py", line 22, in _wrapped_view
    return view_func(request, *args, **kwargs)

  File "/usr/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/site/decorators.py", line 35, in _check
    return view_func(request, local_site=local_site, *args, **kwargs)

  File "/usr/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/reviews/views.py", line 721, in review_detail
    RequestContext(request, context_data))

  File "/usr/lib/python2.7/site-packages/django/shortcuts/__init__.py", line 29, in render_to_response
    return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs)

  File "/usr/lib/python2.7/site-packages/django/template/loader.py", line 164, in render_to_string
    return t.render(Context(dictionary))

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 140, in render
    return self._render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 134, in _render
    return self.nodelist.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 840, in render
    bit = self.render_node(node, context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 854, in render_node
    return node.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/loader_tags.py", line 123, in render
    return compiled_parent._render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 134, in _render
    return self.nodelist.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 840, in render
    bit = self.render_node(node, context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 854, in render_node
    return node.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/loader_tags.py", line 123, in render
    return compiled_parent._render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 134, in _render
    return self.nodelist.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 840, in render
    bit = self.render_node(node, context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 854, in render_node
    return node.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/loader_tags.py", line 62, in render
    result = block.nodelist.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 840, in render
    bit = self.render_node(node, context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 854, in render_node
    return node.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/loader_tags.py", line 155, in render
    return self.render_template(self.template, context)

  File "/usr/lib/python2.7/site-packages/django/template/loader_tags.py", line 137, in render_template
    output = template.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 140, in render
    return self._render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 134, in _render
    return self.nodelist.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 840, in render
    bit = self.render_node(node, context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 854, in render_node
    return node.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/defaulttags.py", line 305, in render
    return nodelist.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 840, in render
    bit = self.render_node(node, context)

  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 854, in render_node
    return node.render(context)

  File "/usr/lib/python2.7/site-packages/django/template/defaulttags.py", line 203, in render
    nodelist.append(node.render(context))

  File "/usr/lib/python2.7/site-packages/djblets/util/decorators.py", line 122, in render
    return self.tag_func(context, *args)

  File "/usr/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/reviews/templatetags/reviewtags.py", line 91, in file_attachment_comments
    file_attachment.get_comments()))

  File "/usr/lib64/python2.7/json/__init__.py", line 243, in dumps
    return _default_encoder.encode(obj)

  File "/usr/lib64/python2.7/json/encoder.py", line 207, in encode
    chunks = self.iterencode(o, _one_shot=True)

  File "/usr/lib64/python2.7/json/encoder.py", line 270, in iterencode
    return _iterencode(o, 0)

  File "/usr/lib64/python2.7/json/encoder.py", line 184, in default
    raise TypeError(repr(o) + " is not JSON serializable")

TypeError: <generator object serialize_comments at 0x7fa32b8c1690> is not JSON serializable


<WSGIRequest
path:/r/72/,
GET:<QueryDict: {}>,
POST:<QueryDict: {}>,
COOKIES:{'collapsediffs': 'True',
 'csrftoken': 'bWdahqG38M6CAFvtTR9Y47epQz7qLjlG',
 'rbsessionid': 'ssf0htw8jx8wrw3jbbz6uip1bey1pskw'},
META:{'CONTEXT_DOCUMENT_ROOT': '/var/www/html/reviewboard/htdocs',
 'CONTEXT_PREFIX': '',
 'DOCUMENT_ROOT': '/var/www/html/reviewboard/htdocs',
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT': 'text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8',
 'HTTP_ACCEPT_ENCODING': 'gzip, deflate, sdch',
 'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.8',
 'HTTP_CONNECTION': 'keep-alive',
 'HTTP_COOKIE': 'collapsediffs=True; rbsessionid=ssf0htw8jx8wrw3jbbz6uip1bey1pskw; csrftoken=bWdahqG38M6CAFvtTR9Y47epQz7qLjlG',
 'HTTP_HOST': 'dev2aig4hg501.eqxdev.exigengroup.com',
 'HTTP_HTTPS': '1',
 'HTTP_REFERER': 'http://*rb*.mycompany.com/r/?show-closed=0',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.89 Safari/537.36',
 u'LOCAL_SITE': None,
 'PATH_INFO': u'/r/72/',
 'PATH_TRANSLATED': '/var/www/html/reviewboard/htdocs/reviewboard.wsgi/r/72/',
 'QUERY_STRING': '',
 'REMOTE_ADDR': '192.168.*.*',
 'REMOTE_PORT': '1362',
 'REQUEST_METHOD': 'GET',
 'REQUEST_SCHEME': 'http',
 'REQUEST_URI': '/r/72/',
 'SCRIPT_FILENAME': '/var/www/html/reviewboard/htdocs/reviewboard.wsgi',
 'SCRIPT_NAME': u'',
 'SERVER_ADDR': '10.23.*.*',
 'SERVER_ADMIN': 'root@localhost',
 'SERVER_NAME': '*rb*.mycompany.com',
 'SERVER_PORT': '80',
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'SERVER_SIGNATURE': '',
 'SERVER_SOFTWARE': 'Apache/2.4.6 (CentOS) OpenSSL/1.0.1e-fips mod_wsgi/3.4 Python/2.7.5',
 'UNIQUE_ID': 'Vd8oU1Qb2bzMGeOPcubv8gAAAAA',
 u'USERNAME': u'admin',
 u'USER_EMAIL': u'my@mycompany.com',
 'mod_wsgi.application_group': 'localhost|',
 'mod_wsgi.callable_object': 'application',
 'mod_wsgi.enable_sendfile': '0',
 'mod_wsgi.handler_script': '',
 'mod_wsgi.input_chunked': '0',
 'mod_wsgi.listener_host': '',
 'mod_wsgi.listener_port': '80',
 'mod_wsgi.process_group': '',
 'mod_wsgi.queue_start': '1440688211807813',
 'mod_wsgi.request_handler': 'wsgi-script',
 'mod_wsgi.script_reloading': '1',
 'mod_wsgi.version': (3, 4),
 'wsgi.errors': <mod_wsgi.Log object at 0x7fa32b9ccab0>,
 'wsgi.file_wrapper': <built-in method file_wrapper of mod_wsgi.Adapter object at 0x7fa32b96bb70>,
 'wsgi.input': <mod_wsgi.Input object at 0x7fa32b9cc470>,
 'wsgi.multiprocess': True,
 'wsgi.multithread': False,
 'wsgi.run_once': False,
 'wsgi.url_scheme': 'http',
 'wsgi.version': (1, 0)}>
#1 atrub******@eisgro****** (Google Code) (Is this you? Claim this profile.) 
Please let me know what is the error reason and what is the way to fix it
chipx86
#2 chipx86 
What kind of files are attached to that review request?

We have a fix coming out in 2.0.20 (probably this week), but were under the assumption from our understanding of the bug that you wouldn't actually manage to hit this in practice. Knowing the type of uploaded files will help us here.
  • +NeedInfo
chipx86
#3 chipx86
#4 alde****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I,ve been hitting the same bug with CSV  files attachments (pure csv from php csv writter) as well as doc and docx.
it blocks the whole review when it happens, no one can look at it
#5 alde****@gmai***** (Google Code) (Is this you? Claim this profile.) 
(FYI 2.0.19 as well, and everything was working before)
chipx86
#6 chipx86 
We'll have 2.0.20 out in just a couple days with this fix.
david
#7 david