3747: Review images is broken

just****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 31, 2015
What version are you running?
Master 1dbdc63

What's the URL of the page containing the problem?
Any image file attachment where there are one or more comments on the image.

What steps will reproduce the problem?
1. Upload an image
2. Comment on the image
3. View the image again

What is the expected output? What do you see instead?
Image should be displayed with the comment, but the image was not displayed and console showed a JS error.

What operating system are you using? What browser?
Mac 10.9.5, Firefox

Please provide any additional information below.
9a1466fd4ea096506e7ff91ca3f01984275ec25b is the first bad commit from git bisect
#1 david
  • +PendingReview
  • +david
#2 david
Fixed in master (51c20e1). Thanks!
  • -PendingReview
#3 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)

Is there a chance this issue also affect document (a .docx)?

on our side we've got a 500 error when displaying review request containing an attachement (.docx) after migration from 2.0.15 to 2.0.19, see call stack:

  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/reviews/templatetags/reviewtags.py", line 91, in file_attachment_comments

  File "/usr/lib/python2.7/json/__init__.py", line 231, in dumps
    return _default_encoder.encode(obj)

  File "/usr/lib/python2.7/json/encoder.py", line 201, in encode
    chunks = self.iterencode(o, _one_shot=True)

  File "/usr/lib/python2.7/json/encoder.py", line 264, in iterencode
    return _iterencode(o, 0)

  File "/usr/lib/python2.7/json/encoder.py", line 178, in default
    raise TypeError(repr(o) + " is not JSON serializable")

TypeError: <generator object serialize_comments at 0x7f2abe9246e0> is not JSON serializable

if confirmed, I can open another issue.


#4 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
I confirm it is the same issue, and David's fix works on any kind of file attachment. It has solved our issue with .docx