3476: Update -> Add File does not have same outcome as drag-and-drop file

stuar******@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 8, 2014
What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Give users the "Can edit review requests" permission.
2. Raise and publish a review request.
3. Other reviewers use "Update -> Add file" to add a file to the review.

What is the expected output? What do you see instead?

Expected: file is uploaded, review is in draft status, the other reviewer see this and press "publish".

Actual: file is uploaded, review is in draft status, other reviewer CANNOT see this (cannot see the newly uploaded file, cannot see the draft status, cannot press "publish").

If step three is "Other reviews drag and drop file onto browser window" instead, then they CAN see the uploaded file and can press "publish".

What operating system are you using? What browser?

Linux. Firefox.

Please provide any additional information below.
#1 david
I can't reproduce this.

Users should never be able to see drafts owned by other users, *unless* the viewing user is an administrator. This is by design. There's no technical difference between how things are created using "Add File" and how they're created by drag and drop.

Can you go back and see if you can check exactly what you're seeing, especially with regards to whether other users are administrators?
  • +NeedInfo
#2 stuar******@gmai***** (Google Code) (Is this you? Claim this profile.)
I've just done this test using ReviewBoard 2.0.2 and can confirm the behaviour:

1. Create new user, "prima".
2. Create new user, "secunda".
3. Give users prima and secunda the "review requests | can edit review requests" permission. Do not give them staff or superuser status.
4. Log in as prima, create any review request. Add secunda to the people. Publish the review request.
5. Log out, then log in as secunda.
6. Read prima's review request.
7. Drag and drop an image file onto the browser window. This uploads the image and puts the review in draft status, visible to secunda.
8. Have secunda click "publish". The review request is published, with the uploaded image.
#3 david
Review Board isn't really designed right now to have multiple users modifying a single review request. I'm going to merge this into the enhancement request asking for collaboration.