2986: Posting paths in Perforce crashes

bijan.******@gmai***** (Google Code) (Is this you? Claim this profile.)
May 29, 2013
2881
What version are you running?

- ReviewBoard v1.7.6
- RBTools v0.5

What's the URL of the page containing the problem?

- Not a bug with ReviewBoard Web
- However, this has to do with using 'post-review' in RBtools to post paths instead of changelists:
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#posting-paths

What steps will reproduce the problem?
1. Submit files under a sample path 

e.g. //depot/my/path/...

2. Attempt to create a review for the folder

e.g. post-review //depot/my/path/...


What is the expected output? What do you see instead?

 The expected output is "Review #nnn posted"

 The resulting output is a TypeError exception with the following stack trace:

Traceback (most recent call last):

  File "D:\Python27\Scripts\post-review-script.py", line 8, in <module>

    load_entry_point('rbtools==0.5', 'console_scripts', 'post-review')()

  File "D:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\postreview.py", line 1308, in main

  File "D:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\clients\perforce.py", line 288, in diff

  File "D:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\clients\perforce.py", line 412, in _path_diff

TypeError: _do_diff() takes at least 7 arguments (7 given)

What operating system are you using? What browser?
- Windows 7 Professional
- Google Chrome  27.0.1453.94 m

Please provide any additional information below.
(patch will be forthcoming...)
#1 bijan.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Patch submitted as ReviewBoard request #4179
http://reviews.reviewboard.org/r/4179/
#2 smacleod