2881: Unable to post a review in Perforce using file rev range.

mec***@gmai***** (Google Code) (Is this you? Claim this profile.)
May 29, 2013
2892, 2986
What version are you running?
    I'm running RBTools 0.4.3 (Python 2.7)

What's the URL of the page containing the problem?
    No URL associated with this issue, this is an issue with 'post-review'

What steps will reproduce the problem?
    1. Using Perforce, commit some changes to your repository
    2. Try to create a review using a file range (e.g.: //depot/myProject/src/main/com/java/MyClass.java#1,#4)
    3. A TypeError exception should be raised with the exception of: _do_diff() takes at least 7 arguments (7 given)

What is the expected output? What do you see instead?
    I expected to see a review created. Instead, an exception was thrown and I was unable to create a review.

What operating system are you using? What browser?
    Ubuntu 12.04.1 AMD64

Please provide any additional information below.
   I've supplied the diff I used to get file rev ranges to work on my system.
<                 dl = self._do_diff(old_file, new_file, depot_path,
<                                    base_revision, changetype_short,
<                                    ignore_unmodified=True)
>                 dl = self._do_diff(old_file=old_file, 
>                                     new_file=new_file, 
>                                     depot_path=depot_path,
>                                     base_revision=base_revision, 
>                                     new_depot_path=None, 
>                                     changetype_short=changetype_short,
>                                     ignore_unmodified=True)
#1 david
  • +Component-RBTools
#2 Faller******@gmai***** (Google Code) (Is this you? Claim this profile.)
Same as 2892 http://code.google.com/p/reviewboard/issues/detail?id=2892
#4 ata****@gmai***** (Google Code) (Is this you? Claim this profile.)
The fix for this is trivial. Sent it out for review...

#5 smacleod
Fixed in master, release-0.5.x. Thanks!
  • +Fixed