2050: Filtering files to review

gotisc******@yaho**** (Google Code) (Is this you? Claim this profile.)
Feb. 4, 2014
1026
http://reviews.reviewboard.org/


What version are you running?
1.5.1

What's the URL of the page this enhancement relates to, if any?
"All review requests", "My Dashboard", "View Diff"; sort of "My/Users Settings"

Describe the enhancement and the motivation for it.
I looked for similar requests/issues here, but didn't find... As reviewer, I don't want to see binary files, properties, xml files etc. while reviewing. Our review requests are created automatically by post-commit hook. As one possibility to make what I want is to create a wrapper for that hook command line which creates request to filter files I am not interested in. The problem is that somebody can be interested in reviewing xml or property files as well. I would be glad to have:

1) a setting that I want to review "java, js" files only. After setting it I would not see requests with other files (if they do not have java or js files); 

2) when I review request I would not see changes of other files. 

3) to improve usability it can be sort of checkbox "to filter files or not" so anybody could easy switch between modes. E.g. I see some code and I need to check related xml file commited (if any), then I don't need to change my settings by just "exit" filtered mode.

What operating system are you using? What browser?


Please provide any additional information below.
#1 anna****@gmai***** (Google Code) (Is this you? Claim this profile.)
A simple file filter can help people do the following (for example):
1. Show *.java
2. Hide *.xml
3. Hide *.js

4. Show */ui/* (show UI project code changes)
5. Show */backend/* (show backend project code changes)
6. Hide */reports/* (hide reports poject code changes)

#2 gotisc******@yaho**** (Google Code) (Is this you? Claim this profile.)
Seems like it is related to this issue:
I am a default reviewer, in my settings I've specified a regular expression .*\.java to be default reviewer for java files. Now on my dashboard I see only requests with java files, but I get mails for all requests (even for those which do not have java files at all). Do I miss anything? Is here any special checkbox to make it synchronized (so I want to receive only letters for my requests which I see on my dashboard)? 
#3 gotisc******@yaho**** (Google Code) (Is this you? Claim this profile.)
would it be an option to have checkboxes for every file changed on "View Diff" page in "Files Changed" area? Each checkbox tells if related file should be shown or hidden. At the beginning, all checkboxes can be set according to default reviewer file regex if it is, or all boxes selected if nothing entered there.
david
#4 david
  • +Component-Reviews
david
#5 david