1655: "Reply" to the previous comment button in diff view just takes you to review view

hadr****@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 7, 2010
1426 
What version are you running?
1.5 beta 1

What steps will reproduce the problem?
1. go to some review request that has diff attached and diff has published 
comment for some line
2. go to diff view
3. click on the line comment marker (you should get a window to put your 
comments, and , to the left another window with previous comments)
4. click "reply" link on the left pane next to the previous comment

What is the expected output? 
you're taken to the add comment to review screen (adding new comment to 
review, that included the comment we clicked "reply" to)

What do you see instead?
user is taken to the "review view", page not even scrolling to the 
appropriate review

What operating system are you using? What browser?
Linux x86, Opera 10.10, Opera 10.5x, FF 3.6.3, Konqueror 4.2.2
#1 dgib*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
The "right" action here, in my opinion, would be to open a "reply" text box without changing pages.
chipx86
#2 chipx86 
Yes, but we need to figure out the interaction there, because in order for the comment to be public, you have to publish it (which today must happen on the reviews page). So, it's a little unclear if we just add a textbox. There was a patch up for review that added this but had some issues and was never completely fixed.

This won't happen for 1.5, but we can look into it for a future release.
david
#3 david
  • +Component-Reviews
david
#4 david