1426: "Reply" on the diff page is confusing and error-prone.

vmih*****@gmai***** (Google Code) (Is this you? Claim this profile.)
1655, 2559, 2910, 3148, 3160, 3568, 3920
What version are you running?

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. Open a comment in the diff view and then press the reply link/button

What is the expected output? What do you see instead?
To go to the reviews page placed on the right comment. I am just redirected  
to the review page. 

What operating system are you using? What browser?
Windows. Tested with Chrome and Firefox

Please provide any additional information below.
#1 Bugea******@gmai***** (Google Code) (Is this you? Claim this profile.)
I have also seen this issue on Firefox on Linux.
When you click on "reply" you are taken to a URL something like
the munged one below but nothing happens.


#2 sch****@gmai***** (Google Code) (Is this you? Claim this profile.)
Same problem happening in 1.1 alpha3. Reply button on the comment dialog popup jumps
to the top of the review page, but doesn't open a comment edit field.
#3 lon***@gmai***** (Google Code) (Is this you? Claim this profile.)
Issue is still present in 1.5 Beta 1 too.

I was wondering what is the expectation:

1) go back to the reviews view and open the add comment dialog (which is really add

2) or stay in the diff view and open a reply dialog box (or replace the behavior of
the current one)?

Most of our users would prefer to stay in the diff view when replying to a comment.
#4 david
  • +Component-Reviews
#6 jira*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I can reproduce this in RB 1.6 beta.

OS: Mac OS
Browser: Firefox 3.6.13

URL: http://<sitedir>/r/###/diff

1. Look at a review request
2. Select view diff
3. Click somewhere on the diff to comment & save it
4. Click on the previous comment area
5. Select reply from the comment's pop-up
#8 david
  • +"Reply" on the diff page is confusing and error-prone.
#11 rewil*****@thesb***** (Google Code) (Is this you? Claim this profile.)
I just ran into this and lost a bunch of comments in the process. A team member posted a new diff on a review, so I was reviewing it. He'd replied to one of my comments on the previous diff and closed the issue. I wasn't satisfied, so I wanted to reopen it and reply to his comment on the newest diff. While in diff view, I could see my original comment and his reply, but when I clicked the reply button in the comment dialog, I was just taken back to the main review page. No text field was opened up and pre-selected for me, and even worse, when I returned to the diff view, I'd lost all the comments I already wrote on my in-progress review update.

What I would expect is that when I click reply, I get presented with a text field in which to type my reply, right in-situ. Click save, and it's done. Then it all gets submitted when I actually publish the review. I shouldn't have to leave the page to reply to a comment, and I absolutely should never lose comments already entered, especially with nary a warning.

Safari 6.0.2.
#12 kiw****@gmai***** (Google Code) (Is this you? Claim this profile.)
The documentation itself says :
"The comment box is not the place to reply to those comments. Instead, you can click the Reply link next to the particular comment, which will take you back to the review request page and open a reply box."

I expected from this that when clicking the reply button a reply box would open on the new page. It doesn't (RB 1.7.6).
#13 sume****@gmai***** (Google Code) (Is this you? Claim this profile.)
the fix is to probably allow entering comments from the diff page. why should a user have to navigate to a different page and lose their place in order to reply?
#15 david
Bug 3160 added some interesting observations about the "Add Comment" button:

What's the URL of the page this enhancement relates to, if any? http://site/r/1/diff/

Describe the enhancement and the motivation for it.
1. Person A posts a comment/review
2. Person B clicks on the blue bubble or on the same line number
3. Person B sees the previous comment in a blue box and a green box ready for input that says "Add comment".
3. Person B is confused on whether the green box is a reply or a new comment.

I would expect that the title of the green box is "New comment", as "Add comment" can be read as adding a comment/reply to the review comment seen in the blue box.

What operating system are you using? What browser? Windows 7, Firefox

Please provide any additional information below.

This is related to issue 1426, but I feel it is a separate issue (issue 1426 is about the confusion when clicking the reply button, this about the confusion on whether you need to click the reply button or whether the nice big text box is already a reply).

I plan to address this in a translation file for now (along with translating "Submitted" to "Completed", but I can understand that that may not be universally better), but having it more clear in the actual application would be preferred.
#17 esha*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I agree 1000% with comment #13. Having the reply button cause you to navigate away from the diff is the cause of the confusion; being able to add replies in place would alleviate that. 
#18 mat****@salsita******** (Google Code) (Is this you? Claim this profile.)
Also agree 1000%.
#22 xelepart

This bug has been getting re-posted over and over for years, with lots of people agreeing with it. I also find this annoying, as do most of the people I work with. Is it really so complex that it can't be addressed? I'd rather the "reply" link just not exist than do what it does right now. I'm perfectly able to navigate over to the reviews myself, and then at least I know it's going to happen. Everyone I've ever talked to expects it to open a response textarea inline without reloading the page.