1246: "Last Updated" column always shows same timestamp as "Diff Updated".

josh.h*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 30, 2012
1266, 1405, 2160
What version are you running?

What's the URL of the page containing the problem?
Any user's dashboard.

What steps will reproduce the problem?
1. Set up the dashboard to show "Diff Updated" and "Last Updated" fields.
2. Create a review.
3. Wait several minutes.
4. Go into the review and edit the "testing" field, for example.
5. Refresh the dashboard.  Note how the "Last Updated" field still reflects
the same timestamp as "Diff Updated" despite the edit just made to the review.

What is the expected output? What do you see instead?
I'd expect "Last Updated" to show the time when any change was made to the
review, not just a diff update.  This was actually the behavior in 1.0
alpha 4 (and possibly newer releases, but that was the last one we used
before upgrading).

What operating system are you using? What browser?

Please provide any additional information below.
#2 david
  • +Component-Dashboard
#4 lanp*****@gmai***** (Google Code) (Is this you? Claim this profile.)
help, v1.5.4 still has this issue.
#5 car***@netap***** (Google Code) (Is this you? Claim this profile.)
It looks like Reviewboard is using the last_review_timestamp date from the reviews_reviewrequest instead of the timestamp field from the diffviewer_diffset table of the latest diff.
#7 david
Fixed in master (937722d), and will ship with 1.7. Thanks!
#8 david
  • +Fixed