1075: Include submitted review requests in the "Starred Reviews" page in the dashboard.
- Fixed
- Review Board
| sebastie*********@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Sept. 20, 2013 | |
| 3302 |
What steps will reproduce the problem? 1. Go to "All review request" page. 2. Show submitted review and star a submitted one. 3. Go to your dashboard. The review doesn't appear in the "Starred reviews" category. What is the expected output? What do you see instead? I guess we should see it even if the code has been submitted. To keep track of great exemples of reviews for instance. Thank you.
1.0 beta 2 downloaded from the release download directory.
I would like to add that starring a not yet submitted review works fine.
Oh, I see. Submitted reviews. Well, this is actually very much intentional. In the next version we may introduce support for showing submitted reviews in the dashboard, but we don't want to make that the default. Repurposing this bug as an enhancement request for this.
-
- NeedInfo + Confirmed -
- Type-Defect + Type-Enhancement + Milestone-Release1.5 + Component-Dashboard -
+ Add the ability to show submitted review requests in the dashboard.
-
+ Milestone-Release1.6
-
- Milestone-Release1.6 + Milestone-Release1.6.x -
- Add the ability to show submitted review requests in the dashboard. + Add the ability to show other users' submitted review requests in the dashboard.
I think it's definitely worth including submitted review requests in the "Starred Reviews" page, since it's a way that people save things they're interested in. This should be a nice candidate for a student to poke at soon.
-
- Milestone-Release1.6.x + Milestone-Release1.8 + EasyFix -
- Add the ability to show other users' submitted review requests in the dashboard. + Include submitted review requests in the "Starred Reviews" page in the dashboard.
I volunteer to poke at this one!
What do we do after we fix the bug? Put our patches up for review?
Yes, that's exactly right. You'll want to commit your changes to a topic branch, and then post it up on http://reviews.reviewboard.org/ Let us know if you have any questions about that process.