1066: Show file status in diff (added, modified, deleted, renamed)

veste*****@gmai***** (Google Code) (Is this you? Claim this profile.)
March 17, 2012
655, 1317 
It would be useful to to show a status in front of the files in the diff 
screen. 

 Added     src\file.cpp
 Modified  src\file2.cpp
 Moved     src\file3.cpp (moved from src\file4.cpp)
 Copied    src\file5.cpp (copied from src\file6.cpp)
 Deleted   src\file7.cpp

The changeset overview in track does this, and it is very helpful to get a 
quick understanding of what the changes are. The same information could be 
included with the filenames in the side-by-side diff.

Since it seems post-review is just uploading a diff file, this would 
probably require either adding some extra meta information to the diff file 
or creating a separate diff-metadata file?
#1 veste*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Type should be changed from Defect to Enhancement
chipx86
#2 chipx86
  • +Confirmed
  • -Type-Defect
    +Type-Enhancement
    +Component-DiffViewer
    +Milestone-Release1.5
david
#3 david
david
#4 david
chipx86
#5 chipx86
  • +Milestone-Release1.6
#6 berna******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Suggestion: What about the post-commit tool to post the output of "svn status" as a
Text attachment (once RB supports Text attachments). :)
chipx86
#7 chipx86 
The deleted part of this is up for review at http://reviews.reviewboard.org/r/1685/. This part should end up in 1.5. The rest will wait until 1.6 or later.
chipx86
#8 chipx86 
We now have the deleted part for CVS. It'll be added for other types of repositories in 1.6.
chipx86
#9 chipx86
  • +Priority-High
chipx86
#10 chipx86 
The deleted support for Git and Perforce are up for review.

Rename indication is harder. The info is provided in Perforce, I believe, but the others are more tricky. I think we can infer it in Git (we'll see a delete and an add, and a common SHA1 in each).

Not so sure we're going to get Copy indication at all. I'm limiting this for now to Delete, and then to Move.

We're going to try to limit the scope of the 1.6 release to some UI improvements, diff compatibility, and basic policy/access control support. So I'm pushing the remaining work for Move to 1.7. We may be able to pull back if we have time.
  • -Milestone-Release1.6
    +Milestone-Release1.7
david
#12 david
  • -Confirmed
    +Fixed