1052: Submitting a review should not trash unpublished changes

macne*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 28, 2009
What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. Edit the description. Do not publish it.
2. Click Close -> submit

What is the expected output? What do you see instead?
The user should either be prompted to publish changes or the changes should
simply be saved.

Whats actually happening is the changes disappear. It is a reasonable use
case that a user would want to add some metadata when marking the review as
subbmited. The change number, date deployed, whatever. The current workflow
requires them to publish, which means there is email sent to team members
which they actually don't need to get.

What operating system are you using? What browser?
Shouldn't matter. Linux RB host. mac os client w/ firefox.

Please provide any additional information below.
#1 chipx86
  • +Confirmed
  • +Milestone-Release1.0.x
#2 david