832: post-review for perforce. don't submit if changelist is empty

tph***@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 6, 2010
What's the URL of the page containing the problem?
post-review script

What steps will reproduce the problem?
1. create empty numbered changelist or by moving open files out
2. run post-review <changelist>
3. server returns "HTTP Error 500: Internal Server Error"
4. blank review request created

What is the expected output? What do you see instead?
Diff should die if there's no files to process. 

What operating system are you using? What browser?
FC4, Firefox2

Please provide any additional information below.
Running RB 0.9.dev_20081201-py2.4.egg
#1 david
  • +Component-RBTools
#3 ben.h*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I have a review out to fix this: http://reviews.reviewboard.org/r/1886/
#4 david
Fixed in rbtools 65eec92.
  • +Fixed