808: post-review goes into infinite loop sometimes when valid cookie found but can't login

nithi******@gmai***** (Google Code) (Is this you? Claim this profile.)
April 14, 2009
What's the URL of the page containing the problem?
Using post-review

What steps will reproduce the problem?
1. I believe this happens when doing a post-review after a server upgrade.

What is the expected output? What do you see instead?
Review created. 
I see 
>>> Loaded valid cookie -- no login required
>>> Attempting to create review request for 314558
>>> HTTP POSTing to <server>

in an infinte loop. For some reason, it's not able to login with the
existing cookie and it calls itself recursively and fails with a stack

What operating system are you using? What browser?
Ubuntu Server, Windows xp Client, Firefox

Please provide any additional information below.
#1 chipx86
Hopefully something we can fix for 1.0, but it may be pushed back to 1.5.
  • +Confirmed
  • +Component-Scripts
#2 chipx86
Fixed in r1902.
  • -Confirmed
  • +chipx86