576: Discarded request should be listed in all view

hui****@luukk***** (Google Code) (Is this you? Claim this profile.)
david
 david
Jan. 22, 2014
1150 
If you discard a review request you can't see it in 'all review requests'
view.  It would be good if you could still see a record of discarded
requests - after all there's another button for delete.

For now you can see discarded requests in admin pages only.
chipx86
#1 chipx86
  • -Type-Defect
    +Type-Enhancement
    +Component-Dashboard
david
#2 david
  • +Confirmed
#3 cuv****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I'd like to see an explicit "rejected" state instead of modifying the discard
behavior.  To me, discard is a sort of "nevermind" that any user can apply to their
review requests, and these should rightly not be listed anymore in the "all" view. 
Delete is only available to staff users, and completely wipes the review from the
database, so it should rarely be used.

"Rejected" would be a closure state that says, "This request was considered, but
deemed not appropriate to commit, and no further revisions will be attempted."
chipx86
#4 chipx86 
That seems reasonable to me.
david
#5 david
david
#6 david
  • -Confirmed
    +PendingReview
  • +david
david
#7 david 
Fixed in master (734ba4b). This will ship in 2.0 beta 3.
  • -PendingReview
    +Fixed