camtarn

5070: Example docker-compose.yaml files should have a restart line for reviewboard container

camtarn 
What version are you running?


master


What's the URL of the page containing the problem?


https://github.com/reviewboard/reviewboard/tree/master/contrib/docker/examples




What steps will reproduce the problem?


    

  1. Install ReviewBoard via example docker-compose.mysql.yaml (also works with .postgres.yaml)
    2. 

  2. Have the ReviewBoard container exit for some reason (e.g. reboot, crash, OOM)
    3. 





What is the expected output? What do you see instead?


Expected: 'reviewboard' container should restart.

Actual: 'reviewboard' container does not restart, and disappears from 'docker ps'. If 'nginx' container restarts for some reason, it enters a restart loop as it cannot resolve the 'reviewboard' DNS name from Docker.




What operating system are you using? What browser?


Linux, Ubuntu 24.04.4 LTS. Browser not relevant.




Please provide any additional information below.


Required fix: add "restart: 'on-failure'" to docker-compose.mysql.yaml and docker-compose.postgres.yaml. See diff here:


https://github.com/reviewboard/reviewboard/compare/master...camtarn:reviewboard:master?expand=1