4981: Upload diff file from web ui fails when choose repository from filtered results


What version are you running?

ReviewBoard 5.0 (just upgrade from 3.0.15

What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. type anything to the filter on the left.
  2. choose any repository.
  3. upload a diff file.

What is the expected output? What do you see instead?

Expected output: move to review request draft

Actual output: stuck with loading icon.

And server response with 404 (trying to access /nullapi/validation/diffs/)

What operating system are you using? What browser?

Ubuntu 20.04 and chrome 106.0.5249.119, but it seems irrelevent.

Please provide any additional information below.

It seems repository from filtered result will have localSitePrefex = null, instead of "".


You can see the validateDiffModel.es6.js handle the attribute diffently from the others. so the null is being prepend to the api url cause the problem.

#1 maubin

Thanks for the report, we were able to reproduce the problem and are working on a fix for it. The fix will be available in 5.0.1.

  • -New
  • +maubin
#2 maubin

This issue has been fixed in 5.0.1.

  • -PendingReview