4977: When creating review request from existing SVN commit, diffs don't work for files with non UTF-8 characters
- Review Board
What version are you running?
What's the URL of the page containing the problem?
[review board server]/r/[review request]/diff/1/
What steps will reproduce the problem?
- Have an SVN repository.
- Have an existing file encoded in ISO 8859-1, with non-UTF-8 characters in it, for example an ISO 8859-1 '°' (0xB0).
- Commit a change to the existing file.
- In Review Board, do New Review Request, select the SVN repository, and select the made commit.
What is the expected output? What do you see instead?
Expected: A review request is created that shows the committed diff.
Instead: The diff in the review request shows the following error message:patching file [file]-new (read from [file]) Hunk #[X] FAILED at [line]. 1 out of 8 hunks FAILED -- saving rejects to file [file].rej
What operating system are you using? What browser?
Chrome or Edge.
Please provide any additional information below.