4977: When creating review request from existing SVN commit, diffs don't work for files with non UTF-8 characters


What version are you running?


What's the URL of the page containing the problem?

[review board server]/r/[review request]/diff/1/

What steps will reproduce the problem?

  1. Have an SVN repository.
  2. Have an existing file encoded in ISO 8859-1, with non-UTF-8 characters in it, for example an ISO 8859-1 '°' (0xB0).
  3. Commit a change to the existing file.
  4. In Review Board, do New Review Request, select the SVN repository, and select the made commit.

What is the expected output? What do you see instead?

Expected: A review request is created that shows the committed diff.

Instead: The diff in the review request shows the following error message:

patching file [file]-new (read from [file])
Hunk #[X] FAILED at [line].
1 out of 8 hunks FAILED -- saving rejects to file [file].rej

What operating system are you using? What browser?

Windows 10.
Chrome or Edge.

Please provide any additional information below.