4971: "invalid literal for int" when expanding collapsed lines in a multi-commit review

phord
chipx86
chipx86

What version are you running?

4.0.4.2

What's the URL of the page containing the problem?

https://codereviews.purestorage.com/r/149627/diff/1/?base-commit-id=8758

What steps will reproduce the problem?

  1. Create a multi-commit review
  2. Select a limited diff first/last range
  3. View the diff and try to expand some collapsed code lines by clicking the "plus" icon.

What is the expected output? What do you see instead?

Expected to see lines expand.

Instead I see a "A server error occurred."

What operating system are you using? What browser?

Linux. Chromium.

Please provide any additional information below.

There was an error displaying this diff.
invalid literal for int() with base 10: '2895831chunk/22/'

This may be a a temporary outage or an issue with the format of your diff.

Please try again, and if you still have trouble, contact support.

Details
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/views.py", line 418, in get
kwargs)
File "/usr/local/lib/python2.7/dist-packages/reviewboard/reviews/views.py", line 1645, in process_diffset_info
kwargs)
File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/views.py", line 631, in process_diffset_info
diffset=diffset)
File "/usr/local/lib/python2.7/dist-packages/django/shortcuts.py", line 85, in get_object_or_404
return queryset.get(args, kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py", line 371, in get
clone = self.filter(*args,
kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py", line 787, in filter
return self._filter_or_exclude(False,
args, kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py", line 805, in _filter_or_exclude
clone.query.add_q(Q(*args,
kwargs))
File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/query.py", line 1250, in add_q
clause, _ = self._add_q(q_object, self.used_aliases)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/query.py", line 1276, in _add_q
allow_joins=allow_joins, split_subq=split_subq,
File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/query.py", line 1210, in build_filter
condition = self.build_lookup(lookups, col, value)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/query.py", line 1104, in build_lookup
return final_lookup(lhs, rhs)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/lookups.py", line 24, in init
self.rhs = self.get_prep_lookup()
File "/usr/local/lib/python2.7/dist-packages/django/db/models/lookups.py", line 74, in get_prep_lookup
return self.lhs.output_field.get_prep_value(self.rhs)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/fields/init.py", line 966, in get_prep_value
return int(value)
ValueError: invalid literal for int() with base 10: '2895831chunk/22/'

chipx86
#1 chipx86

Fixed in Review Board 4.0.7 (coming this week).

Commit 53de1446814f460a87587c039a53ebafcbbe0e00

  • -New
    +Fixed
  • +Release-4.0.x
  • +Component:DiffViewer
  • +chipx86