phord

4949: Posting update to a closed review causes draft confusion

phord 
What version are you running?


3.0.18.12


What's the URL of the page containing the problem?


https://codereviews.mycompanyname.com/r/135725/


What steps will reproduce the problem?


    

  1. Post an update draft to a closed review (using RBTools)
    2. 

  2. View the updated review in the web GUI
    3. 





What is the expected output? What do you see instead?


I expect my changes to be rejected or to show as a draft when viewed in the web GUI.


Instead, when I view the review in the web interface it shows my draft changes as if they are submitted as part of the (still closed) review. It does not tell me this is a draft and it does not allow me to discard (or submit) the draft changes.  


To be clear, the diff, summary, description and commit hash were all "updated" on the review page and the header said "This change has been marked as submitted" with no indication that the changes shown were completely different from what was shown when it was closed.


This is very confusing since the diff shown to the author is different from the diff shown to other users and no indication is given that the diff is from an unsubmitted draft.


What operating system are you using? What browser?


Linux. Chromium.


Please provide any additional information below.


I was able to fix the problem by reopening the review. Then I could see the Draft status and could choose to discard it. After that I closed the review again. Sadly, my review got updated needlessly to show the open/close events some 8 months after the initial closure.