4944: Clicking on the dropdown arrow next to the "Publish" button in the Review Editor overlay closes the overlay


What version are you running?

4.0.5(alpha 0 dev)

What's the URL of the page containing the problem?

Any review request page.

What steps will reproduce the problem?

  1. In a pre-existing review request, click on the "Review" button
  2. When the review overlay comes up, move the mouse so that it hovers over the down arrow next to the "Publish" button at the bottom of the overlay
  3. Click on the mouse
  4. If nothing happens, move the mouse away, and return. It seems to happen only intermittently.

What is the expected output? What do you see instead?

Clicking the arrow should do nothing except bring up the little menu of publishing options.

What I'm actually seeing is that sometimes, the overlay is closed, and then the Review Request is put into a weird state on the client side where I can't re-review it, and when I attempt to reload the page, the beforeunload event handler is being handled so that the browser asks if I actually want to navigate away, even though there are no edited fields visible.

What operating system are you using? What browser?

I'm on macOS 11.6 Big Sur, using Firefox Nightly 94.0a1

Please provide any additional information below.

Here's a screen recording I did showing the issue:


#1 mconley
  • +mconley
#2 david

Fixed in release-5.0.x (06ae91d). This will ship in 5.0.1. Thanks!

  • -New