4941: EXCLUDE_FILES doesn't work properly


What version are you running?

Reviewboard v4.0.2 (official Docker container), rbtools 2.0.1 (Python 3.9.6)

What steps will reproduce the problem?

  1. Add a folder with files you want to exclude to your repo. Let's call it exc. Add a file to it, exc/file.txt.
  2. Add the following settings to .reviewboardrc:
  1. Commit everything, push to tracking branch (say, master).
  2. On a different branch, add a line to exc/file.txt. Also, make another change that shouldn't be ignored: add a new file called another.txt to the root.
  3. Start a review: rbt post origin/master..HEAD
  4. Open the diff link presented.

What is the expected output? What do you see instead?

I expect the excluded files not to show up in the diff.

If you select the whole diff, first commit to last (which is the default), the excluded files are shown.
If you narrow down to single commits, none of the commits contain the excluded files (which is OK)

What operating system are you using? What browser?

Arch Linux (rolling release, updated today). Firefox 91.0.

Same thing happens on Windows, Firefox 90.0.2.

Both systems have rbtools 2.0.1, running Python 3.9.6

#1 andrej_at_elaphe

I figured out where the error is and posted a fix: https://reviews.reviewboard.org/r/11794/

#2 andrej_at_elaphe

Is this not an issue for everybody else? Should I try harder to explain the issue? Post screenshots?

I posted a simple fix, this could be reviewed and merged in 10 minutes.

#3 david

We did see your patch, we've just been very busy and haven't been able to get around to it yet.

#4 andrej_at_elaphe

OK, I understand that. Thanks for the acknowledgement.

#5 david

Fixed in release-2.0.x (97d6a9a). This will ship in RBTools 2.0.2. Thanks!

  • -New
#6 andrej_at_elaphe

Thank you!