4862: tabs in issues section gets back to "Open issues" every 10 seconds when some checks/tests are updating results.

theBoss

What version are you running?

3.0.14

What's the URL of the page containing the problem?

internal

What steps will reproduce the problem?

  1. Create review wich check duration long enough to be able to create issues for the code
  2. In the issues section switch to "Resolved issues" tab
  3. After some time around 10s, tab will get back to "Open issues"

What is the expected output? What do you see instead?

Around every 10s RB will switch tab in issues section to "Open issues"

What operating system are you using? What browser?

Firefox 72.0.2 on Windows 10, same issue on Linux (Debian Stable)

Please provide any additional information below.

When review request is running checks and one of them has pending status update then every 10 seconds reviewboard send request _updates/?entries=initial_status_updates:0&api_format=json. Probably, 'get' method of ReviewRequestUpdateViewclass is called. This method returns HttpResponse with view template - 'reviews/review_issue_summary_table.html' with request, issue_counts and issues as RequestContext. The template has hard-coded class 'active' in open issues tab. Due to that after every _updates/ request tab is switched to Open Issues if user currently looking at other type of issues (waiting for verification/resolved/dropped/all issues). It disturbs reviewboard workflow and makes almost impossible to analyse issues with status other than open. Even though HttpRequest contains status 304 (NOT MODIFIED) issue summary table is swapped with content of request which result in tab switch.