4838: Handle adding empty, renamed and moved files in diffviewer
- ThirdParty
- Review Board
| cyran.norbert | |
What version are you running?
3.0.14
What's the URL of the page this enhancement relates to, if any?
/r/{id}
Describe the enhancement and the motivation for it.
Reviewboard seems to completely ignore diffs with empty files. If there are only additions of empty files, reviewboard rejects the diff because it's "empty". If additions are among other changes, reviewboard cuts it out of the diff and they're not visible in the diffviewer.
Reviewboard also badly handles renaming and moving files, showing in diffviewer file deleted completely and added again in another path. Please handle those cases to make code review more convenient and accurate.
What operating system are you using? What browser?
OS and browser independent
Please provide any additional information below.
Can you confirm what version control system you're using?
Also, how are you creating your diffs? If you're using RBTools, what version?
-
- New + NeedInfo
Subversion. I create diffs with svn di. Not tested with rbt
I tried with rbt now, adding empty files works well
You'll have to use rbt here. "svn diff" produces output that doesn't have enough information for Review Board to know about the empty files.
-
- NeedInfo + ThirdParty