48: Add "number of lines changed" to dashboard view

Feb. 16, 2014
2036, 3472
It'd be helpful for prioritizing work to have an indication as to the size
of an attached diff shown in the dashboard view.
#1 david
  • +Component-Dashboard
#2 tle****@gmai***** (Google Code) (Is this you? Claim this profile.)
A single-line summary like "8 files added; 2 files deleted; 11 files modified. 182
lines." would be useful, and shouldn't be too hard to generate.
#3 chipx86
So, this isn't going to be a quick and easy change.

Yes, we can generate that info, but the right way to do so would be to process the
diff when the user goes to upload it (which has the advantage of verifying that it's
not a broken diff before we actually make it available to view), and then store those
stats in the FileDiff and DiffSet models. FileDiff should have fields for number of
total lines in the file and number of lines added/deleted/modified. From that, we can
gather whether the file was completely added or completely deleted.

We could then use that info in the dashboard for a column. The column would be pretty
long, and I'd like to find a more compact way to represent it, but the hard part will
be the above.
  • +Add "number of lines changed" to dashboard view
#4 david
  • +Confirmed
#8 jahidt******@gmai***** (Google Code) (Is this you? Claim this profile.)
so is there anything for the solution on Reviewboard? I also need the number of lines changed for a revision, and it would be quite handy if Reviewboard provided it.
#9 david
  • -Confirmed
  • +david
#10 david
Fixed in master (7ba68fe). Whoo!
  • -PendingReview