4798: "There was an error displaying this diff." for any SVN file that no longer exists at its former location

a-dogg

What version are you running?

3.0.5

What's the URL of the page containing the problem?

https://rb.corp.linkedin.com/r/1197363/diff/3/

What steps will reproduce the problem?

  1. Create a review-request for an SVN repository
  2. Move or delete one or more of the files that were in the diff, in the SVN repository

What is the expected output? What do you see instead?

Expect to see a diff rendered.
Instead:

   There was an error displaying this diff.

  The file '("'....", ...)' could not be found in the repository

   This may be a bug in the software, a temporary outage, or an issue
   with the format of your diff.

   Please try again, and if you still have trouble,
   contact support.

What operating system are you using? What browser?

N/A

Please provide any additional information below.

The folder exists at the revision specified in the diff, as seen in $ svn ls -r${REVISION} output.

Also svn cat ${PATH}@${REVISION} outputs the file contents.

chipx86
#1 chipx86

How's the diff being generated? Is this svn diff, RBTools, or an in-house product?

  • -New
    +NeedInfo
a-dogg
#2 a-dogg

We use an in-house product which runs RBTools "under the hood".

It looks like SVN recognizes the base revision - see attached screenshot.