4747: When a new widget on the Admin Dashboard is added, in some cases the page will crash.


What version are you running?

Reviewboard release-4.0.x

What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. On release-4.0.x, navigate to /admin/ and load the dashboard normally.
  2. Add a new widget onto the page, using extensions or "Add Small Widgets" button.
  3. Reload the /admin/ page.

What is the expected output? What do you see instead?

The expected output is that the admin dashboard should reload, with your new widget displaying on the page. Instead, the page crashes with a "Key Error".

What operating system are you using? What browser?

I'm on Ubuntu 18.04, using Firefox 62.0 (64-bit)

Please provide any additional information below.

We suspect this is because the new widget is not given a position in the page, if the dashboard was already generated for the user.

We broke this during development, when attempting to add a new secondary widget into the dashboard. If you had release-4.0.x /admin/ loaded on a page, then added code that added a new widget, then reloaded the page, that would also trigger the page to have a key error.

#1 skaefer143

I can fix this, I think this is an easyfix.

#2 david

Fixed in release-3.0.x (88448fc). Thanks!

  • -New