4718: rbtools.utils.execute returns non-unicode

Misery
david
david

What version are you running?

1.0

What steps will reproduce the problem?

  1. Use Python 2.7.14
  2. Call execute cmdline (see at the bottom)
  3. Result is "str" instead of "unicode". This leads to 'ascii' codec can't decode byte 0xc3 in position 4: ordinal not in range(128)

t = '{author} ({date|isodatesec}) [{node|short}] [{branch}]:\n{desc}'
cmd = ['hg', 'log', '-r', '1', '--template', t]
type(execute(cmd))

0.7.11: type is unicode
1.0: type is str

After git bisect it looks like it was introduced by 1daa6263bff62ba0d8284d69677c0504340e965c

What is the expected output? What do you see instead?

RBTools 0.7.11 works out of the box. RBTools 1.0 throws some UnicodeDecodeErrors.

What operating system are you using?

Linux

Please provide any additional information below.

Misery
#1 Misery

Oh, wrong changeset.... I mean f158f41e98a48ccca23eb8bbee76352aab6b65e5

david
#2 david
  • +david
david
#3 david

Fixed in release-1.0.x (a9305e7). This will ship in 1.0.2. Thanks!

  • -New
    +Fixed