Here's the latest...

  • No new tickets were filed this week. That's a relief.
  • No tickets were closed this week. Better get on that.

Some recent discussions you might care about...

jackdai
#2 jackdai

PC:~/test_rbtools/rbtools$ git remote
origin

PC:~/test_rbtools/rbtools$ git log --graph --pretty=oneline --all
237829813e98f5ec993c66d84302546c4c46ea7d test
ecf67273a68199ff9e89d73884e3600dbcaedcf3 testing
6b9ccfb367c5f784ac120db2c7da9be26cfa1cc4 add testing file
523333759932242a161033bb8841fdf33661e3a0 Initial commit

PC:~/test_rbtools/rbtools$ rbt diff --parent 237829813e98f5ec993c66d84302546c4c46ea7d
WARNING: Could not determine specific upstream remote to use for diffs. We recommend setting TRACKING_BRANCH in reviewboardrc to your nearest upstream remote branch.
CRITICAL: Failed to execute command: [u'git', u'rev-parse', u'523333759932242a161033bb8841fdf33661e3a0^']

david
#1 david

In order to diagnose this, it would help to have the output of the following two commands (please upload the second as a file attachment):

git remote
git log --graph --pretty=oneline --all

alebastr
#1 alebastr

Two more tracebacks from rbt diff -d command:

>>> Running: git log 8f934ac10ec3fcba20b9bb4359a7240ce06f3295
Traceback (most recent call last):
  File "c:\python3\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "c:\python3\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Python3\Scripts\rbt.exe\__main__.py", line 9, in <module>
  File "c:\python3\lib\site-packages\rbtools\commands\main.py", line 120, in main
    command.run_from_argv([RB_MAIN, command_name] + args)
  File "c:\python3\lib\site-packages\rbtools\commands\__init__.py", line 725, in run_from_argv
    exit_code = self.main(*args) or 0
  File "c:\python3\lib\site-packages\rbtools\commands\diff.py", line 77, in main
    extra_args=extra_args)
  File "c:\python3\lib\site-packages\rbtools\clients\git.py", line 636, in diff
    no_renames)
  File "c:\python3\lib\site-packages\rbtools\clients\git.py", line 784, in make_diff
    return self.make_perforce_diff(merge_base, diff_lines)
  File "c:\python3\lib\site-packages\rbtools\clients\git.py", line 913, in make_perforce_diff
    ['p4', 'files', base_path + filename + '@' + p4rev],
TypeError: can't concat str to bytes

>>> Running: git log 8f934ac10ec3fcba20b9bb4359a7240ce06f3295
>>> Running: p4 files //depot/<...>@3037715
Traceback (most recent call last):
  File "c:\python3\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "c:\python3\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Python3\Scripts\rbt.exe\__main__.py", line 9, in <module>
  File "c:\python3\lib\site-packages\rbtools\commands\main.py", line 120, in main
    command.run_from_argv([RB_MAIN, command_name] + args)
  File "c:\python3\lib\site-packages\rbtools\commands\__init__.py", line 725, in run_from_argv
    exit_code = self.main(*args) or 0
  File "c:\python3\lib\site-packages\rbtools\commands\diff.py", line 77, in main
    extra_args=extra_args)
  File "c:\python3\lib\site-packages\rbtools\clients\git.py", line 636, in diff
    no_renames)
  File "c:\python3\lib\site-packages\rbtools\clients\git.py", line 784, in make_diff
    return self.make_perforce_diff(merge_base, diff_lines)
  File "c:\python3\lib\site-packages\rbtools\clients\git.py", line 914, in make_perforce_diff
    ignore_errors=True, results_unicode=False)
  File "c:\python3\lib\site-packages\rbtools\clients\git.py", line 1225, in _execute
    return execute(cmdline, cwd=self._git_toplevel, *args, **kwargs)
  File "c:\python3\lib\site-packages\rbtools\utils\process.py", line 155, in execute
    **popen_encoding_args)
  File "c:\python3\lib\subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "c:\python3\lib\subprocess.py", line 1119, in _execute_child
    args = list2cmdline(args)
  File "c:\python3\lib\subprocess.py", line 530, in list2cmdline
    needquote = (" " in arg) or ("\t" in arg) or not arg
TypeError: a bytes-like object is required, not 'str'
david
#1 david

Fixed in release-1.0.x (a32dadb). This will ship in 1.0.3. Thanks!

david
#1 david

I'm not able to reproduce this problem.

Do you think you could trace through parse_revision_spec in rbtools/clients/perforce.py and see what the revisions list looks like and where it's failing to parse it correctly?