4712: Internal Error when getting status updates when a previous status update is error.


What version are you running?


What's the URL of the page containing the problem?

What steps will reproduce the problem?

  1. Post a status update with the state "error"
  2. Query for all status updates
  3. Notice internal error

What is the expected output? What do you see instead?

Expected the list of status updates, got internal error (500).

What operating system are you using? What browser?

Hosting -> CentOS 7
Browsing -> Windows 10, Chrome

Please provide any additional information below.

#1 david

Do you have a traceback from the log file?

  • -New
#2 jcannon

Not on me, the issue is at https://github.com/reviewboard/reviewboard/blob/master/reviewboard/reviews/models/status_update.py#L154
Simple logic bug of using is instead of == for string comparison.

#3 jcannon

Fix posted at https://reviews.reviewboard.org/r/10058/

#4 jcannon

Attaching log

  • +
    2018-07-03 16:35:34,715 - ERROR - None - user - /api/review-requests/4/status-updates/ - djblets.log.middleware - Exception thrown for user user at
    Invalid state "E"
    Traceback (most recent call last):
      File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/venv/lib/python2.7/site-packages/django/core/handlers/base.py", line 112, in get_response
        response = wrapped_callback(request, *callback_args, **callback_kwargs)
      File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/venv/lib/python2.7/site-packages/django/views/decorators/cache.py", line 52, in _wrapped_view_func
        response = view_func(request, *args, **kwargs)
      File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/venv/lib/python2.7/site-packages/django/views/decorators/vary.py", line 19, in inner_func
        response = func(*args, **kwargs)
      File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/venv/lib/python2.7/site-packages/djblets/webapi/resources/base.
#5 chipx86

Thanks for the fix! It's on release-3.0.x (4d321f4f30a83152c53e2dc3cd38962948cefd66) and going out today.

  • -NeedInfo
  • +Release-3.0.x
  • +Component:Reviews