jcannon

4712: Internal Error when getting status updates when a previous status update is error.

jcannon 
What version are you running?


3.0


What's the URL of the page containing the problem?


http://192.168.79.134/api/review-requests/3/status-updates/


What steps will reproduce the problem?


    

  1. Post a status update with the state "error"
    2. 

  2. Query for all status updates
    3. 

  3. Notice internal error
    4. 





What is the expected output? What do you see instead?


Expected the list of status updates, got internal error (500).


What operating system are you using? What browser?


Hosting -> CentOS 7

Browsing -> Windows 10, Chrome


Please provide any additional information below.
david
#1 david 
Do you have a traceback from the log file?
  • -New
    +NeedInfo
jcannon
#2 jcannon 
Not on me, the issue is at https://github.com/reviewboard/reviewboard/blob/master/reviewboard/reviews/models/status_update.py#L154

Simple logic bug of using is instead of == for string comparison.
jcannon
#3 jcannon 
Fix posted at https://reviews.reviewboard.org/r/10058/
jcannon
#4 jcannon 
Attaching log
  • +
    reviewboard.log 
    2018-07-03 16:35:34,715 - ERROR - None - user - /api/review-requests/4/status-updates/ - djblets.log.middleware - Exception thrown for user user at http://192.168.79.134/api/review-requests/4/status-updates/?max-results=100
    Invalid state "E"
    Traceback (most recent call last):
      File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/venv/lib/python2.7/site-packages/django/core/handlers/base.py", line 112, in get_response
        response = wrapped_callback(request, *callback_args, **callback_kwargs)
      File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/venv/lib/python2.7/site-packages/django/views/decorators/cache.py", line 52, in _wrapped_view_func
        response = view_func(request, *args, **kwargs)
      File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/venv/lib/python2.7/site-packages/django/views/decorators/vary.py", line 19, in inner_func
        response = func(*args, **kwargs)
      File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/venv/lib/python2.7/site-packages/djblets/webapi/resources/base.
    
 
    

    


    
   
    • 


  


 








 

  

   chipx86

  

 
 

  

    
     

   
   #5
   chipx86


  


  
Thanks for the fix! It's on release-3.0.x (4d321f4f30a83152c53e2dc3cd38962948cefd66) and going out today.



  
    


   
  • 
    
    
    -NeedInfo
    +Fixed
    
   
    • 



   
  • 
    
    
    +Release-3.0.x
    
   
    • 



   
  • 
    
    
    +Component:Reviews
    
   
    •