4692: Can’t toggle interdiff control on iPad

grossag

What version are you running?

3.0.3

What's the URL of the page containing the problem?

Any review

What steps will reproduce the problem?

  1. On an ipad (or maybe even any any touchscreen?) go to the diff view on a review with multiple diffs
  2. try to change the interdiff control to have the left side switch from "orig" to 1 or 2

What is the expected output? What do you see instead?

i expect to be able to drag the toggle on either side to be able to switch the interdiff. but instead it just tries to highlight the control. if i tap on a number enough times, the right side will switch over, but i can never get the left side to move

What operating system are you using? What browser?

iPad with the latest version of iOS running Safari

Please provide any additional information below.

david
#1 david
  • +Component:DiffViewer
    +EasyFix
grossag
#2 grossag

It's been 3 years since I filed this but I just wanted to mention that this would still be really useful. I'm still unable to do interdiff manipulation on iPhone or iPad because it doesn't support dragging via touch. So I still have to manipulate the URL to pick the interdiff range.

chipx86
#3 chipx86

Hey Adam,

Yeah, this was part of a series of UI changes that got pushed back (there's a lot of things competing for our time.

I have some in-progress work for adding touch control and accessibility to this slider. It's missing the Review Board 4.0 release window, but I'm planning to get it into a 4.0.x.

akim.ruslanov
#4 akim.ruslanov

Hey there,

Will be now working on this!