4682: Interdiff sometimes missing changes


What version are you running?

RB 3.0.3
RBTools 0.7.8
hg 4.2.3

What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. Post a review
  2. Upload a new diff
  3. View interdiff (e.g. using 'Show Changes' link)

What is the expected output? What do you see instead?

Expect to see all changes, but some are missing.

What operating system are you using? What browser?

Firefox 59.0.1, FC26

Please provide any additional information below.

See attached screenshot for an example: one would expect the first #endif line to be red, and the second green. But they don't appear as changes, and the second one isn't even shown unless the context is expanded.

#1 alexander

Can confirm that this happened to us as well, using SVN repo.

#2 marko.koschak

This also happened to us. We are using RB 3.0.8 and git.

It is easily reproducible when the second commit deletes lines which contains already deleted lines from the first commit.
To clarify:
- e.g. original file has 100 lines of code
- first commit deletes lines 20 - 30 of the original file
- second commit deletes lines 15 - 45 of the original file

Now the interdiff between orig - 1 shows the 10 deleted lines correctly.
The interdiff between orig - 2 also shows correctly the 30 deleted lines.
But the interdiff between 1 - 2 is broken. It shows only a couple of lines from Diff Revision 1.