4679: Cannot save bug tracker settings for trac or jira

Misery
chipx86
chipx86

What version are you running?

3.0.5

What's the URL of the page containing the problem?

http://localhost/admin/db/scmtools/repository/1/

What steps will reproduce the problem?

  1. Select a repository
  2. Select jira or trac as bug tracker
  3. enter a valid url
  4. press save
  5. See that is cleans the url field and say that the field is required and needs to be entered.

What is the expected output? What do you see instead?

Success

What operating system are you using? What browser?

Linux, Firefox 59

Please provide any additional information below.

If I switch to required=False in JIRAForm class it can "save" without an error but the field is still empty.
There is no difference if I remove validators.

Seems Review Board checks for the wrong variable.

Misery
#1 Misery

(Custom bug tracker) still works without a problem.

Misery
#2 Misery

Seems broken by https://github.com/reviewboard/reviewboard/commit/3c414d0a18dc812d3aeca2bdfad8721a05592fb8 :-(

Misery
#3 Misery

self.data.get('hosting_type') is still "custom" even if I select "jira"

Misery
#4 Misery

Ah, sorry, hosting_type is ok.... I'm giving up here.

Misery
#5 Misery

Checked a fresh RB 3.0.3 - switching to trac or jira works there.

chipx86
#6 chipx86

Fix up for review. https://reviews.reviewboard.org/r/9900/

Sorry this took so long. Had some other priorities to attend to. Release with this will be out in a little over a week.

  • -New
    +PendingReview
  • +Release-3.0.x
  • +Component:Admin
  • +chipx86
chipx86
#7 chipx86

Fixed on release-3.0.x (d1e67884bad1042a3308fdc0d4f3ef8816dce9b4).

  • -PendingReview
    +Fixed