4650: Support disabling updating "Groups" and "People" when updating RB using "rbt post"

erwaman

What version are you running?

2.5.6.1

Describe the enhancement and the motivation for it.

"rbt post --guess-fields no" disables updating the Summary and Description. However, the "Groups" and "People" fields still get updated if TARGET_GROUPS and TARGET_PEOPLE are set in your .reviewboardrc file. I generally have a default set of groups and people that I set TARGET_GROUPS and TARGET_PEOPLE to, but sometimes I'll add additional outside reviewers. The problem is that when I update an RB using "rbt post --guess-fields no -r 123456", the "Groups" and "People" fields still get updated (set to TARGET_GROUPS and TARGET_PEOPLE), so I end up having to re-add the non-default groups and people I originally added. It would be nice to support updating an RB with a new revision but not updating any fields in the RB, including Groups and People.

Please provide any additional information below.

david
#1 david

With luck, we just had a contribution to fix this (using the values in .reviewboardrc only for newly created review requests instead of for updates).

Fixed in rbtools master (40f55b3). This will ship in RBTools 1.0.

  • -New
    +Fixed
#2 erwaman

Wow! Thanks, Ryan, for the fix, and David for shepherding this through! I'm going to talk to my Tools team immediately and ask them to install the latest build of RBTools :).

david
#3 david

One thing to note is that this is going to ship in RBTools 1.0, which is probably a couple months out. You're welcome to run from the master branch, but beware that there might be some bugs.

#4 erwaman

Ah, gotcha. Just poked around our Tools repos and found that we're building against RBTools 0.7.6. Will keep an eye out for the RBTools 1.0 release!