4607: Trying to sort by fullname in "Users" page cause "error 500".


What version are you running?

Not related but I tested it in:
3.0 RC2(in http://demo.reviewboard.org/r/)

What's the URL of the page containing the problem?

What steps will reproduce the problem?

  1. Enter "Users" page (or "Submitter" in older version)
  2. Try to be "smart" and sort by "fullname" changing url to ?page=1&letter=all&sort=-fullname
  3. Get error 500 forever

What is the expected output? What do you see instead?

What operating system are you using? What browser?

Please provide any additional information below.

It's related to djblets because when you change url to sort by "fullname" which is name of column in reviewboard/datagrids/grids.py then djblets try to sort (sort_list created in djblets/datagrid/grids.py in "load_state") that datagrid by "get_full_name" field in users model. Since "get_full_name" is method we are getting FieldError. It's especially annoying because it saves to accounts_profile.sort_submitter_columns in database. Good thing is that it can be reverted writing "username" in url.

Btw it was "reported" few years ago:

#1 david
  • +EasyFix
#2 roman

I'd like to look into this to get familiar with some of the code. Is that alright?

#3 gojeffcho


#4 david

Fixed in djblets release-1.0.x (4a094ea). This will ship in Djblets 1.0.9. Thanks!

  • -New