mckownam

4602: Add Support for Privately-Hosted BitBucket Repositories

mckownam
4195 
What version are you using?


2.5.10 and 2.5.16




Which module(s) does this relate to?


Types of repositories that Reviewboard can connect to.




Describe the enhancement and the motivation for it.


The enhancement would be to allow for adding connection parameters for a privately-hosted BitBucket instance rather than just assuming that BitBucket repositories are all at bitbucket.org. The GitLab repository hosting option already has something like this, so a similar adaptation should allow for privately-hosted BitBucket repositories to also work with Reviewboard. 


This request is being made because choosing the custom hosting method and just plain Git results in an error when trying to connect to the repository and obviously since the repository is from a privately-hosted BitBucket instance, the existing BitBucket hosting option within Reviewboard does not work. 




Please provide any additional information below.


    

  1. In Reviewboard 2.5.10, when trying to connect to the privately-hosted BitBucket repository url (as a custom hosted repository and Git as the source control) the repository creation page throws the following error: "'in <string>' requires string as left operand"
    2. 

  2. In Reviewboard 2.5.16, the same settings as above results in the repository page indicating that there is an error "Please correct the error below.", but no error output is displayed, nor are any input fields highlighted as having errors. 
    3. 

  3. I do not know if this is the case for all privately-hosted BitBucket instances, but our production and sandbox servers are both using port 8443, not 443. 
    4.
mckownam
#1 mckownam 
One update: In the additional information section: 

4. Our self-hosted BitBucket repository URL structure is as follows: https://my-bitbucket-server.com:8443/baseFolder/Project/Repo.git
david
#2 david 
Despite having the same name, privately hosted Bitbucket ("Bitbucket Server") is a completely separate product from bitbucket.org (it was an acquisition of a tool called "Stash"). We're going to be including support for Bitbucket Server repositories in an upcoming release of Power Pack. You can get in touch with us at support@beanbaginc.com if you'd like to test a prerelease.
david
#3 david