seb

4576: RB crashes when trying to create new review request from a subversion repository

seb 
What version are you running?


2.5.15


What's the URL of the page containing the problem?


http://reviewboard.taitradio.net/r/new/


What steps will reproduce the problem?


    

  1. Select a subversion repository
    2. 

  2. Select one of the recent commits in the list
    3. 



What is the expected output? What do you see instead?


I expected a new review request to be created.

Instead a message box opened saying that there was an "Internal server error 500".


What operating system are you using? What browser?


Ubuntu 16.04.3 LTS

Chrome 60.0.3112.101-1


Please provide any additional information below.


I get the attached stack trace emailed.
trace.txt 
Traceback (most recent call last):
  File "/home/reviewboard/.venv/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/reviewboard/.venv/local/lib/python2.7/site-packages/django/views/decorators/cache.py", line 52, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/home/reviewboard/.venv/local/lib/python2.7/site-packages/django/views/decorators/vary.py", line 19, in inner_func
    response = func(*args, **kwargs)
  File "/home/reviewboard/.venv/local/lib/python2.7/site-packages/djblets/webapi/resources/base.py", line 199, in __call__
    request, method, view, api_format=api_format, *args, **kwargs)
  File "/home/reviewboard/.venv/local/lib/python2.7/site-packages/djblets/webapi/resources/mixins/api_tokens.py", line 65, in call_method_view
    return view(request, *args, **kwargs)
  File "/home/reviewboard/.venv/local/lib/

 






  


 










 

  

   chipx86

  

 
 

  

    
     

   
   #1
   chipx86


  


  
Would it be possible to share the repository URL that's configured in Review Board? It's fine to substitute path/hostnames, but I need the structure intact (all slashes, all dots).



  
    


   
  • 
    
    
    -New
    +NeedInfo
    
   
    • 



   
  • 
    
    
    +SCM:Subversion
    
   
    • 


  


 








 

  

   seb

  

 
 

  

    
     

   
   #2
   seb


  


  
I assume you are referring to the URL of the subversion repository in question as configured under Admin/Repositories?! If so, it is "http://svnhost.tait.co.nz:3180/svn/research" (without the quotes).


Let me know if I can help with any other information for investigating this.



 








 

  

   chipx86

  

 
 

  

    
     

   
   #3
   chipx86


  


  
Okay, this looks to be a behavior change in subvertpy. It used to work like PySVN in that you could pass paths relative to the Subversion repository URL, but that's not the case anymore, so we'd have to alter the subvertpy backend to join the paths. This will require some work.


I'd really suggest using PySVN instead. It has much better compatibility and builds for most systems.



 








 

  

   seb

  

 
 

  

    
     

   
   #4
   seb


  


  
I'll have a look whether I can switch to PySVN. If it is available via pip, it shouldn't be an issue. If not, then it may be a bit more of a problem ....



 








 

  

   david

  

 
 

  

    
     

   
   #5
   david


  



  
    


   
  • 
    
    
    -NeedInfo
    +SetupIssue
    
   
    •