4568: There is no way to discard changes to fields when discarding a review request


What version are you running?


What's the URL of the page containing the problem?

What steps will reproduce the problem?

  1. Publish a review request.
  2. Discard the review request.
  3. Reopen the review request.
  4. Edit the description. Accept the change.
  5. Click "Discard review request".

What is the expected output? What do you see instead?

I expect that any changes I make are publicly visible only if I explicitly choose to a "publish" action. However, the changes to the description get saved even though I tried to discard them. I ran into this because I accidentally used post-review (I do not expect rbt to be different) to post a different change for review but accidentally reused the wrong review ID, thereby accidentally updating a discarded review request. I then tried to discard my update, but doing so committed the new change description.

(Also of note is that the changes to the description do not appear in the "Review request changed" update.)

What operating system are you using? What browser?

Firefox 55.0b13 x64, Windows 7 SP1 x64

Please provide any additional information below.

#1 chipx86

Confirmed to still be an issue on 2.5.x.