4559: Some keyboard shortcuts are broken in 2.5.12 and above


What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. Navigate to a review
  2. Click on diff
  3. Type any of the following:
    Previous file: a, A, K, P:, <, or m
    Next file: f, F, J, N, >

What is the expected output? What do you see instead?

Should move to the next or previous file depending on which key you press

What operating system are you using? What browser?

Windows 10 - Chrome 58.0.3029.110 and Internet Explorer

Please provide any additional information below.

Was working prior to us upgrading to 2.5.12 (was on early 2.5.x). http://reviews.reviewboard.org also seems to have this issue.

#1 chipx86

Fix going in for 2.5.14.

  • -New
  • +Release-2.5.x
  • +Component:DiffViewer
  • +chipx86
#2 chipx86

Fixed on release-2.5.x (f01005217fc0bf4f712f4b2902916127cea46550)

  • -Confirmed
#3 tylwright

Thanks chipx86!