4551: Allow rbt diff to take --no-renames argument for GIT repos


What version are you running?

RBTools 0.7.9

Describe the enhancement and the motivation for it.

rbt diff is running git diff in the backend to get the DIFF.
GIT diff supports "--no-renames" arguments,
but there's no way to pass "--no-renames" to rbt diff to use.

Please provide any additional information below.

#1 brennie
  • +bleblan2
#2 bleblan2

Review request published.

#3 totoroliu

hi~ is there any update to this?
or the pull-request has been merged and released?

#4 totoroliu

It looks like your review #9221 https://reviews.reviewboard.org/r/9221/ has been committed back in Nov 2017.
I just updated to the latest RBTools 1.0.1,
but it seems I'm still unable to run "rbt diff --no-renames" nor unable to see --no-renames feature from "rbt diff --help".

How do I use this --no-renames feature?

#5 bleblan2

I just found the emails for your replys in my junk mail folder. I just took a look at the commit history on the rbtools repo and the commit for this merge doesn't exist so from what I can tell this feature is still not available in any published rbtools versions.

#6 totoroliu

Do you know when your change can be merged?
or could you create another pull-request to be merged into next rbtools release?

#7 bleblan2

Looks like the was a force push at some point that removed the commit from the history. I'm working with the team to get the changes back into the repo so that it can be included in a future release.

#8 david

Re-landed it on release-1.0.x (f5b269b). This will ship in 1.0.2.

  • -New