4542: Publishing attachment name change causes serialization error when webhook is enabled


What version are you running?

2.5.7 / 2.5.9

What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. Create webhook on review_request_published event
  2. Create review request with file attached and publish it
  3. Change attachment name and hit publish (or use PUT vie Web API)

What is the expected output? What do you see instead?

Attachment name is changed and review request draft is public without error

What operating system are you using? What browser?

CentOS7, latest Chrome

Please provide any additional information below.

Log attached. Review request number and attachment number are 5.

None - fetchreviewed - /reviewboard/api/review-requests/5/draft/ - Exception thrown for user fetchreviewed at http://localhost/reviewboard/api/review-requests/5/draft/
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/decorators/cache.py", line 52, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/decorators/vary.py", line 19, in inner_func
    response = func(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/djblets/webapi/resources/base.py", line 196, in __call__
    request, method, view, api_format=api_format, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/djblets/webapi/resources/mixins/api_tokens.py", line 65, in call_method_view
    return view(request, *ar
#1 david
  • +EasyFix