4500: "rbt post" of a submitted Perforce changelist is missing the "Change" field.

Bulletmagnet
4484

What version are you running?

0.7.7 (but 0.7.6 behaves the same)

What steps will reproduce the problem?

  1. Submit a review request for a submitted Perforce changelist

What is the expected output? What do you see instead?

On the right hand side, I expect to see this:

Information
Submitter: myself
Repository: My Project
Branch:
Bugs:
Depends On:
Change: 2655413 (pending)
Reviewers *
Groups:
People:

Instead, I see this:

Information
Submitter: myself
Repository: My Project
Branch:
Bugs:
Depends On:
Reviewers *
Groups:
People:

What operating system are you using?

Ubuntu 14.04 LTS

Attach the debug out from the command.

$ rbt post --debug 2655413
>>> RBTools 0.7.7
>>> Python 2.7.6 (default, Oct 26 2016, 20:30:19) 
[GCC 4.8.4]
>>> Running on Linux-3.13.0-105-generic-x86_64-with-Ubuntu-14.04-trusty
>>> Home = /home/myself
>>> Current directory = /home/myself/workspace/eddie
>>> Command line: rbt post -d 2655413
>>> Checking for a Perforce repository...
>>> Running: p4 info
>>> Running: diff --version
>>> repository info: Path: my.perforce.server:1666, Base path: None, Supports changesets: True
>>> Making HTTP GET request to http://my.reviewboard.server/api/
>>> Running: p4 info
Generating diff for range of submitted changes: 2655412 to 2655413
>>> Writing "//dev/my/project/file.cpp#2" to "/tmp/tmp2kjQWp"
>>> Running: p4 print -o /tmp/tmp2kjQWp -q //dev/my/project/file.cpp#2
>>> Writing "//dev/my/project/file.cpp#3" to "/tmp/tmpBMQn7n"
>>> Running: p4 print -o /tmp/tmpBMQn7n -q //dev/my/project/file.cpp#3
>>> Running: diff -urNp /tmp/tmp2kjQWp /tmp/tmpBMQn7n
>>> Command exited with rc 1: [u'diff', u'-urNp', '/tmp/tmp2kjQWp', '/tmp/tmpBMQn7n']
>>> Making HTTP GET request to http://my.reviewboard.server/api/validation/diffs/
>>> Cached response for HTTP GET http://my.reviewboard.server/api/validation/diffs/ expired and was modified
>>> Making HTTP POST request to http://my.reviewboard.server/api/validation/diffs/
>>> Making HTTP GET request to http://my.reviewboard.server/api/review-requests/?only-links=create&only-fields=
>>> Cached response for HTTP GET http://my.reviewboard.server/api/review-requests/?only-links=create&only-fields= expired and was modified
>>> Making HTTP POST request to http://my.reviewboard.server/api/review-requests/
>>> Making HTTP GET request to http://my.reviewboard.server/api/review-requests/189/diffs/?only-fields=
>>> Added cache entry for HTTP GET request to http://my.reviewboard.server/api/review-requests/189/diffs/?only-fields=
>>> Making HTTP POST request to http://my.reviewboard.server/api/review-requests/189/diffs/
>>> Making HTTP GET request to http://my.reviewboard.server/api/review-requests/189/draft/?only-fields=commit_id
>>> Added cache entry for HTTP GET request to http://my.reviewboard.server/api/review-requests/189/draft/?only-fields=commit_id
>>> Fetching description for changelist 2655413
>>> Making HTTP PUT request to http://my.reviewboard.server/api/review-requests/189/draft/
Review request #189 posted.

Please provide any additional information below.

Works correctly for a pending changelist

#1 Bulletmagnet

Review Board 2.5.6.1