4492: "submitted TIME ago" message is wrong when comments are added to submitted review requests


What version are you running?

2.0.20, but I have confirmed that this bug still exists on demo.reviewboard.org (running 3.0 alpha 0 (dev)).

What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. Create a review request.
  2. Mark the review request as submitted.
  3. Wait some amount of time.
  4. Add a comment to the review request.

What is the expected output? What do you see instead?

At the top of the review request originally was a message that looked like:

Review Request #69 - Created Oct. 10, 2016 and submitted 3 weeks ago

After adding a comment, the message looks like:

Review Request #69 - Created Oct. 10, 2016 and submitted 0 minutes ago

This is wrong. The message either should say "updated" instead of "submitted" or it should use the proper submit time rather than the update time.

What operating system are you using? What browser?

Windows 7 Enterprise x64 SP1, Firefox 50.0.1 (32-bit)

Please provide any additional information below.

#1 chipx86

Need to investigate if this is still happening. Could be that we just need to scan ChangeDescriptions for the one with the status change and use that timestamp.

  • +Component:Reviews
#2 tbrockma


#3 giuliacm

I'll take this one!

#4 david

Fixed in release-3.0.x (0756e8c). This will ship in 3.0.2. Thanks!

  • -New