4468: "Files" list appears blank when loading the review request page


What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. Load a review request with some file attachments
  2. Watch as the "Files" list appears blank until the attachments finally load in

What is the expected output? What do you see instead?

Ideally, we would show some form of placeholder while the attachments are loading. It looks broken otherwise.

A good basic option would be a spinner and some text saying "Loading file attachments..."

Please provide any additional information below.

The reason this happens is because the file attachments are rendered client-side, and won't appear right away, but the section header is there. Providing the visual feedback showing it's loading will do a lot to help keep this from appearing broken.

#1 chipx86
  • -New
  • +Release-2.5.x
  • +EasyFix
#2 annic

working on this one

#3 brennie
  • +annic
#4 david

Fixed in release-3.0.x (5a87118). This will ship in 3.0 beta 1.

  • -Confirmed